[Help Needed] Converting P8 extensions to P10

[OneAngryGamer]

I keep having difficulty converting P8 extensions to work in P10.

I would welcome tips from any P8 developer who has successfully converted their extensions to P9/10. Any difficulties you encountered and what their solution was could end up being very useful to me.


My limited understanding of the changes I need to make when converting:

• rename ps1 scripts to psm1
  
• most of the P8 single value fields (e.g. region) are now multi value. So rework code to use -contains instead of -eq
  
• Platform names have changed. Some have been dropped, new ones have been added, some have been renamed. So any code that references renamed platforms needs to use the new P10 values.
  

What I am currently having difficulty with is when you have applied all of the above changes and the code still will not work on P10.

To give an example, I take what is probably the most simple P8 extension I have created here and I make the changes from ps1 to psm1 etc. but when I try to run this in P10, it doesn't work. The log message is:

ERROR|GameMenu:Game menu extension action failed.
System.Management.Automation.PSArgumentNullException: Cannot process argument because the value of argument "commandInfo" is null. Change the value of argument "commandInfo" to a non-null value.
  at System.Management.Automation.PowerShell.AddCommand(CommandInfo commandInfo)
  at Playnite.Scripting.PowerShell.PowerShellRuntime.InvokeFunction(String name, List`1 arguments) in C:\projects\playnite\source\Playnite\Scripting\PowerShell\PowerShell.cs:line 271
  at Playnite.Scripting.PowerShell.PowerShellScript.InvokeFunction(String functionName, List`1 arguments) in C:\projects\playnite\source\Playnite\Scripting\PowerShell\PowerShellScript.cs:line 208
  at Playnite.DesktopApp.Controls.GameMenu.<>c__DisplayClass31_2.<AddExtensionItems>b__0(GameMenuItemActionArgs a) in C:\projects\playnite\source\Playnite.DesktopApp\Controls\Menus\GameMenu.cs:line 606
  at Playnite.DesktopApp.Controls.GameMenu.<>c__DisplayClass31_3.<AddExtensionItems>b__1(Object _, RoutedEventArgs __) in C:\projects\playnite\source\Playnite.DesktopApp\Controls\Menus\GameMenu.cs:line 652

[Jeshibu]

This would be a lot easier to diagnose if you could post what you've got so far here, or better yet, to github/gitlab or some other public repository.

[OneAngryGamer]

This would be a lot easier to diagnose if you could post what you've got so far here

OK. Attached my attempt at P10 version of Bulk Rename Game Names

[Jeshibu]

Finally got around to this. The trick is not trying to pass parameters to functions via the FunctionName property. You can also use the first and only parameter for those methods to get the selected games instead of the mainview via $PlayniteApi.

function Rename-Game(){
    param($scriptGameMenuItemActionArgs)

    $scriptGameMenuItemActionArgs.Games //this is your selected games
        $scriptGameMenuItemActionArgs.SourceItem //the menu item
}

You can view the source code by unzipping this attachment.

[OneAngryGamer]

The trick is not trying to pass parameters to functions via the FunctionName property. You can also use the first and only parameter for those methods to get the selected games instead of the mainview via $PlayniteApi.

Thanks Jeshibu. I will look at this again after the release of the two new projects I am working on.