Requesting Feedback For Library Plugin

templewulf · (This post was last modified: 06-21-2022, 03:37 PM by templewulf.)

UPDATE:

I have added a marginally more official post in the Library Plugins forum https://playnite.link/forum/thread-1244.html

It includes more convenient instructions for installing via the Playnite client or the add-on database without having to navigate github releases.

That will be the main place I update on the current state of the extension going forward. If I forgot to mention something here, it'll definitely be on that thread and the github repo. Thanks!

Hi all,

Thanks to the help here, I've uploaded a plug-in for keeping track of the game keys from Humble Bundles that I'm sure we've all accumulated over the years. I nearly bought a new game the other day but I only found out *by accident* that I had it in last year's Yogscast bundle!

Please feel free to evaluate both the plugin and the code https://github.com/FiercePunchStudios/Hu.../releases/

Known Issues:

I *just* finished this yesterday when Crow posted that we shouldn't be using Playnite.Common . Fair enough! In that case, can anyone give some guidance on the best way to replace something like `Playnite.Common.Serialization.FromJson<List<string>>` ?
I'm filtering out some of the keys based on the `key_type` field in the Humble json. I know this misses some games, but I'm trying to set up the whitelist to get the best compromise. Let me know if we could improve which games are selected / rejected.

Thanks in advance for your feedback

**Crow** · (This post was last modified: 10-02-2020, 06:26 AM by Crow.)

As far as serialization, just use json.net serialization methods since your extensions already includes that library (it's a dependency of SDK package).

Edit: I will expose those serialization methods in SDK to make it easier for people to use.

DonkeyOatay · (This post was last modified: 10-02-2020, 08:24 AM by DonkeyOatay.)

Doesn't work for me, but I presume that's because I have Playnite 8?

templewulf · 10-05-2020, 03:42 PM

(10-02-2020, 08:24 AM)Donkeyfumbler Wrote: Doesn't work for me, but I presume that's because I have Playnite 8?

Most likely. I made this for 7.9 before Crow posted the requirements to remove references to Playnite.Common. Is there a build up for 8, or did you just compile from master?

DonkeyOatay · 10-05-2020, 03:56 PM

I'm a patron so one of the lucky few to get new major versions two weeks before everyone else. I hope you are able to make the changes when you get your hands on 8.0 yourself as this would be a really useful extension.

templewulf · (This post was last modified: 10-05-2020, 08:43 PM by templewulf.)

(10-05-2020, 03:56 PM)Donkeyfumbler Wrote: I'm a patron so one of the lucky few to get new major versions two weeks before everyone else. I hope you are able to make the changes when you get your hands on 8.0 yourself as this would be a really useful extension.

Oh! I'm only a $1 patron, I forgot about that benefit! Thanks for the tip :-D

I kicked it up to $5 so I could test against 8.0. I confirmed the error in playnite.log

05-10 16:02:28.367|ERROR|ExtensionFactory:Unsupported Playnite assemblies are referenced by Humble Keys Library Importer plugin.

05-10 16:02:28.367|ERROR|ExtensionFactory:Plugin dependencices are not compatible: Humble Keys Library Importer

I replaced references to Playnite.Common, and now it works in Playnite 8, starting with plug-in version 0.1.3. Let me know how you like it! https://github.com/FiercePunchStudios/Hu...y/releases

DonkeyOatay · (This post was last modified: 10-07-2020, 01:15 PM by DonkeyOatay.)

That certainly seems to have done the trick and it is currently busy downloading the metadata for 407 games.

One question - how does it know how to tag a game as redeemed or not redeemed? I presume it is going purely on whether you have clicked to reveal the key on Humble, even if you have not then gone on to add it to Steam?

I plan to delete all the redeemed entries as they will already be in Playnite anyway and I really only want to see the unredeemed keys. I imagine I'm not alone in that so would it be possible to add an option so that you can choose to import only unredeemed entries? I don't want to re-import all of the games again when I use the library again but I would also rather not add 300+ entries to the import exclusion list that Crow recently introduced in Playnite 8.

Thanks a lot for your work on this - really useful

templewulf · 10-07-2020, 02:39 PM

(10-07-2020, 01:14 PM)Donkeyfumbler Wrote: That certainly seems to have done the trick and it is currently busy downloading the metadata for 407 games.

One question - how does it know how to tag a game as redeemed or not redeemed? I presume it is going purely on whether you have clicked to reveal the key on Humble, even if you have not then gone on to add it to Steam?

I plan to delete all the redeemed entries as they will already be in Playnite anyway and I really only want to see the unredeemed keys. I imagine I'm not alone in that so would it be possible to add an option so that you can choose to import only unredeemed entries? I don't want to re-import all of the games again when I use the library again but I would also rather not add 300+ entries to the import exclusion list that Crow recently introduced in Playnite 8.

Thanks a lot for your work on this - really useful

The Humble API returns the key itself in the field `redeemed_key_val`, which is why I used that wording. I just check to see if anything's in that field or not. So far as I know, Humble can't tell what you do with the key once they give it to you.

Do you think "Revealed" / "Unrevealed" would communicate Humble's meaning more clearly?

I'll look at adding that setting in for 0.1.4. Thanks for the feedback!

DonkeyOatay · 10-07-2020, 02:44 PM

I think wording is tricky as redeemed\unredeemed is what the Humble Website uses when it actually just means you have revealed the key (or not) as they obviously can't tell if you then subsequently redeemed it or not.

I'd leave it as it is tbh, with maybe just an explanation on github as to what it actually really means (in case anyone else wonders about it).

Adding the setting would be great - thanks!

templewulf · (This post was last modified: 10-07-2020, 09:15 PM by templewulf.)

I added the setting to 0.1.4, and I also added some of the details we discussed in the README.md.

I also added a method to remove tags and update when the API delivers new key data.

DonkeyOatay · 10-07-2020, 10:01 PM

That's great. Just given it a go and it works perfectly, importing a couple of unredeemed entries I deleted as a test and not importing any of the redeemed keys that I had deleted after the original import.

Thanks again.

You might want to post this on the Discord too which is usually a bit more active than the forums (or if you don't use it I can always do so if you want).

templewulf · 10-08-2020, 05:32 PM

(10-07-2020, 10:01 PM)Donkeyfumbler Wrote: That's great. Just given it a go and it works perfectly, importing a couple of unredeemed entries I deleted as a test and not importing any of the redeemed keys that I had deleted after the original import.

Thanks again.

You might want to post this on the Discord too which is usually a bit more active than the forums (or if you don't use it I can always do so if you want).

That's a good idea! I'll post it today. Thanks again for your feedback!

Gaurnim · (This post was last modified: 01-02-2022, 04:52 PM by Gaurnim.)

Hello,
Are there any plans to migrate this extension to the latest version of Playnite ?
It's currently throwing an error saying that it isn't compatible (Current version of Playnite not supported).

templewulf · 06-09-2022, 03:10 AM

(01-02-2022, 04:51 PM)Gaurnim Wrote: Hello,
Are there any plans to migrate this extension to the latest version of Playnite ?
It's currently throwing an error saying that it isn't compatible (Current version of Playnite not supported).

Hey, thanks for letting me know. I just saw your PM and responded there, but I'll also update here for everyone else.

Some folks mentioned this in an issue on github, and I updated the plugin to work with Playnite 9.18 / SDK 6.2.2. Check for v0.2.0 or higher on the github Releases page.

Gaurnim · 06-14-2022, 10:04 PM

Thanks for updating the extension, it works fine for me.

quincognito · 06-21-2022, 06:54 AM

Loving this extension. I have a _ton_ of stuff sitting around in my Humble account and using this is the first way I've ever been able to get a decent handle on it.

I was wondering: any chance of being able to reflect unclaimed games from Humble Choice purchases?

templewulf · (This post was last modified: 06-21-2022, 03:33 PM by templewulf.)

(06-21-2022, 06:54 AM)quincognito Wrote: Loving this extension. I have a _ton_ of stuff sitting around in my Humble account and using this is the first way I've ever been able to get a decent handle on it.

I was wondering: any chance of being able to reflect unclaimed games from Humble Choice purchases?

You know, I hadn't considered it, since I'm not a Choice subscriber myself. It's not currently on the roadmap, since AFAIK it's pulled from a different Humble API endpoint than the one I use for third-party keys.

Does the built in Humble library not pull the Choice games? I can see an option for it, but as a non-subscriber I have no idea how well it works.