05-18-2022, 05:41 PM
seems like the majority of the time is spent creating the filters. Try disabling them.
|
05-18-2022, 05:45 PM
So unchecking "Enable Filter-SubItemSources" in the addon options seems to dramatically improve performance. I also checked "Keep game index in memory".
(05-18-2022, 05:45 PM)Mellified Wrote: So unchecking "Enable Filter-SubItemSources" in the addon options seems to dramatically improve performance. I also checked "Keep game index in memory". The option to keep the index in memory and having it persist are mutually exclusive. This is also reflected in the settings view now. https://www.dropbox.com/s/b5tibup1r7n59p....pext?dl=1 Also, it logs how many filters are created, when they are enabled. So you can try enabling them again, for testing.
I found the reason for the filters being much slower than they should be, so building the index should be much faster with v2.21.1 when filters are enabled. Searching with filters enabled will probably still have a noticable impact though, but that is really nothing I can change, unless I allow filters with 0 matches into the results.
So I guess QuickSearch should be usable for you again, albeit without the filter functionality. So I hope I can finally consider this issue resolved.
05-19-2022, 05:52 PM
With filters disabled and the other enhancements you've made the plugin is significantly more responsive. Thanks for all the hard work! I use the plugin regularly to check if I own a game before buying bundles and such. It's a huge help.
One minor annoyance - with DuplicateHider enabled I have to keep hidden games in the results in order to see which store(s) I own a game on. It'd be nice for QuickSearch to be DuplicateHider aware and show multiple store icons on a game search result.
07-27-2022, 02:57 PM
(This post was last modified: 07-27-2022, 02:59 PM by BuzStringer.)
Hi, i love this but i have small issue, when start a game from the global search it opens fine the first time.
If i close that game then start a second game from the global search it always starts minimized  Edit: if i restart Playnite, it works ok again for the first time
11-12-2022, 01:00 PM
There's been an issue where this add-on crashes Playnite, since the latest update. It seems repeatable by doing a search with Playnite minimized and then opening the search again with it un-minimized.
11-12-2022, 06:05 PM
(11-12-2022, 01:00 PM)psimetalify Wrote: There's been an issue where this add-on crashes Playnite, since the latest update. It seems repeatable by doing a search with Playnite minimized and then opening the search again with it un-minimized. I cannot replicate this on my side. Can you provide the playnite.log file? You can find it at %appdata%\Playnite.
11-13-2022, 06:58 PM
11-14-2022, 06:19 AM
Just tried it. Same thing, unfortunately.
14-11 06:37:14.609|INFO |PlayniteApplication:Application started from 'C:\Users\psime\AppData\Local\Playnite'
11-14-2022, 06:50 PM
(11-14-2022, 06:19 AM)psimetalify Wrote: Just tried it. Same thing, unfortunately. It's slightly different from the last one. Maybe the latest update at least stops the crashing.
11-15-2022, 01:42 AM
Works now. Awesome!
12-02-2022, 12:09 PM
Could you add some information about the "GitHub Personal Access Token" in Settings?
I checked your github, and it looks like you use it to authenticate as me when querying github for download counts of something, but I didn't chase quite far enough to figure out what. It'd be nice to know that. I'd also like to know what scopes are required for the token. I *think* that a token with no scopes would be enough, since it allows fetching completely public stuff, but it'd be good to be sure. |
|
|
